Conversation
When an existing `headRepo` couldn't be detected, it's time to auto-fork one. Unfortunately, an obscure Go behavior made it seem like `headRepo` was a non-nil value, where in fact it did contain a nil pointer which would crash the process. This avoids ever assigning nil pointers to `var headRepo ghrepo.Interface`.
vilmibm
approved these changes
Apr 1, 2020
Contributor
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
thanks for the quick fix!
mislav
commented
Apr 1, 2020
|
|
||
| // otherwise, determine the head repository with info obtained from the API | ||
| if headRepo == nil { | ||
| headRepo, _ = repoContext.HeadRepo() |
Contributor
Author
There was a problem hiding this comment.
This previously assigned (*api.Repository)(nil) (a null pointer) to a variable with an interface type, which would make the variable erroneously pass the head != nil check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an existing
headRepocouldn't be detected, it's time to auto-fork one. Unfortunately, an obscure Go behavior made it seem likeheadRepowas a non-nil value, where in fact it did contain a nil pointer which would crash the process.This avoids ever assigning nil pointers to
var headRepo ghrepo.Interface. https://golang.org/doc/faq#nil_errorFixes #722