fix: respect GH_FORCE_TTY when running gh pr view#5357
Merged
Conversation
`GH_FORCE_TTY` only affects stdout, not stderr, so this check was failing and the flag was being ignored. I also checked for similar problem in other files but everything else seemed stderr or stdin related. closes cli#5354
cliAutomation
added
the
external
mislav
approved these changes
Mar 29, 2022
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thank you! No tests necessary for such a simple change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH_FORCE_TTYonly affects stdout, not stderr, so this check wasfailing and the flag was being ignored.
I also checked for similar problem in other files but everything else
seemed stderr or stdin related.
Let me know if this needs tests or anything :)
Fixes #5354