Merged
Conversation
Contributor
Author
Contributor
|
@meiji163 hi! thanks for this! this is looking good to me both in terms of code and feature. I'm okay with punting on |
Contributor
|
I whiffed on re-reviewing this before today so it won't make it into this release, but this will go out in the next one. |
vilmibm
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements pinning extensions to release tag or commitish. Fixes #5067
Usage is same as specified by @vilmibm
For binary extensions the pin must be a release tag. It was simplest to add a
Pinnedfield to the manifest.yml.For git extensions the pin can be any commit ref; the extension is then pinned to the commit SHA. Implemented as a "pin file" in the extension's installation directory.
Right now
upgrade --forcewill not override the pin.Todo
--force