X Tutup
Skip to content

Change how gh-cli is installed on fedora#5204

Merged
mislav merged 3 commits intocli:trunkfrom
poplar-at-twilight:patch-1
Feb 17, 2022
Merged

Change how gh-cli is installed on fedora#5204
mislav merged 3 commits intocli:trunkfrom
poplar-at-twilight:patch-1

Conversation

@poplar-at-twilight
Copy link
Copy Markdown
Contributor

gh-cli has entered fedora's official repository and can be installed directly through the '# dnf in gh' command without adding a third-party repository.

gh-cli has entered fedora's official repository and can be installed directly through the '# dnf in gh' command without adding a third-party repository.
@poplar-at-twilight poplar-at-twilight requested a review from a team as a code owner February 14, 2022 10:31
@poplar-at-twilight poplar-at-twilight requested review from mislav and removed request for a team February 14, 2022 10:31
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Feb 14, 2022
@cliAutomation
Copy link
Copy Markdown
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@poplar-at-twilight
Copy link
Copy Markdown
Contributor Author

It seems that this PR is not appropriate. I have not tried installing gh-cli on CentOS and Red Hat Enterprise Linux.

Users in mainland China cannot directly access the repo address of gh-cli. Maybe you can mark that fedora can be installed directly?

Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've tweaked the wording to make the options clearer.

@mislav mislav enabled auto-merge (squash) February 17, 2022 18:35
@mislav mislav merged commit f4b4a4e into cli:trunk Feb 17, 2022
@poplar-at-twilight poplar-at-twilight deleted the patch-1 branch February 18, 2022 01:48
FRANKAAAA67

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup