Conversation
adonovan
force-pushed
the
cs-cp
branch
3 times, most recently
from
730c89b to
a1721cc
Compare
josebalius
reviewed
Oct 18, 2021
Contributor
josebalius
left a comment
josebalius
left a comment
There was a problem hiding this comment.
I took a quick first pass at it. I think we need to solve the user problem as we shouldn't ship with root hardcoded.
mislav
approved these changes
Oct 18, 2021
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
I love this!
Utilizing the remote: prefix for arguments, copying works both ways, right?
Contributor
Author
Yep; you can even copy a mix of local and remote files into a local-or-remote directory, if for some elusive reason you should want to. |
josebalius
approved these changes
Oct 18, 2021
Contributor
josebalius
left a comment
josebalius
left a comment
There was a problem hiding this comment.
Left a question but looks great, I took it for a spin 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 'cs cp' subcommand that copies files between the local and remote file systems, using the "remote:" prefix to indicate the file system of the VM. Argument syntax follows cp and scp convention: one or more source files followed by a destination, which must be directory if there is more than one source. If any source is a directory, the -r (recursive) flag is required.
Fixes #4486