feat(codespaces): added pagination to list subcmd#4516
Merged
Conversation
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
josebalius
reviewed
Oct 14, 2021
Co-authored-by: Jose Garcia <josebalius@github.com>
99458b5 to
66b48c0
Compare
84a00bd to
9c22ab4
Compare
mislav
approved these changes
Oct 21, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you! I've pushed some edits to simplify. I realize that after my changes, JSON isn't supported yet; I plan address to that in a followup PR. Like in other gh commands, JSON rendering will be decoupled from table rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added standardized pagination to the
codespacescmd.