X Tutup
Skip to content

feat(codespaces): added pagination to list subcmd#4516

Merged
mislav merged 10 commits intocli:trunkfrom
shanduur:feat-cs-list-standarized
Oct 21, 2021
Merged

feat(codespaces): added pagination to list subcmd#4516
mislav merged 10 commits intocli:trunkfrom
shanduur:feat-cs-list-standarized

Conversation

@shanduur
Copy link
Copy Markdown
Contributor

Added standardized pagination to the codespaces cmd.

@shanduur shanduur requested review from a team as code owners October 14, 2021 07:40
@shanduur shanduur requested review from mislav and removed request for a team October 14, 2021 07:40
@cliAutomation
Copy link
Copy Markdown
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@shanduur shanduur force-pushed the feat-cs-list-standarized branch from 99458b5 to 66b48c0 Compare October 19, 2021 05:48
@shanduur shanduur requested a review from josebalius October 19, 2021 06:19
@shanduur shanduur force-pushed the feat-cs-list-standarized branch from 84a00bd to 9c22ab4 Compare October 19, 2021 06:48
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've pushed some edits to simplify. I realize that after my changes, JSON isn't supported yet; I plan address to that in a followup PR. Like in other gh commands, JSON rendering will be decoupled from table rendering.

@mislav mislav enabled auto-merge (squash) October 21, 2021 16:40
@mislav mislav merged commit 6759511 into cli:trunk Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup