Use T.TempDir for temporary dirs in tests#3580
Merged
Conversation
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
cristiand391
commented
May 4, 2021
cristiand391
force-pushed
the
tests-tempdir
branch
from
b40753b to
1893b86
Compare
cristiand391
changed the title
T.TempDir for temporal dirs in testsT.TempDir for temporary dirs in tests
cristiand391
force-pushed
the
tests-tempdir
branch
from
1893b86 to
8803d4c
Compare
mislav
suggested changes
May 6, 2021
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thank you for looking out for tests!
Contributor
Author
|
Thanks for the feedback, I've pushed some updates 👍🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
os.TempDirin tests in favor ofT.TempDir.Unlike
os.TempDir,T.TempDirreturn temporary directories that are automatically cleaned up at the end of the test so there's no need to register cleanup functions.Note that this method was introduced in Go 1.15 which is the minimum required version for running the test suite.