X Tutup
Skip to content

Fix link to docs on README.md#304

Merged
vilmibm merged 3 commits intocli:masterfrom
oscard0m:patch-1
Feb 5, 2020
Merged

Fix link to docs on README.md#304
vilmibm merged 3 commits intocli:masterfrom
oscard0m:patch-1

Conversation

@oscard0m
Copy link
Copy Markdown
Contributor

@oscard0m oscard0m commented Feb 5, 2020

Fixes #303

@tierninho
Copy link
Copy Markdown
Contributor

@dominguezcelada Thanks for the quick fix!!! Swapped it to https://cli.github.io/cli/manual/gh as that is the doc page specifically.

@ampinsk
Copy link
Copy Markdown

ampinsk commented Feb 5, 2020

Thank you! We should be fixing this URL soon 😄

Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The docs link is currently defined at the bottom of the file and that'd be the place to correct it (line 77).

@oscard0m oscard0m requested a review from vilmibm February 5, 2020 00:31
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vilmibm vilmibm merged commit 4177413 into cli:master Feb 5, 2020
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
Relates to cli#231

Add the HookRegistry and a small subset of events (AgentInitializedEvent, StartRequestEvent, EndRequestEvent) as a POC for how hooks will work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README.md has link to 'docs' broken

4 participants

X Tutup