X Tutup
Skip to content

view: Add missing newline#2698

Merged
samcoe merged 1 commit intocli:trunkfrom
camelid:view-newline
Jan 4, 2021
Merged

view: Add missing newline#2698
samcoe merged 1 commit intocli:trunkfrom
camelid:view-newline

Conversation

@camelid
Copy link
Copy Markdown
Contributor

@camelid camelid commented Dec 27, 2020

Fixes #2674. Fixes #2706.

Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. gh repo view already had a newline at the end, so
this only changes issue view and pr view.

Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
@camelid
Copy link
Copy Markdown
Contributor Author

camelid commented Dec 27, 2020

#2656 also fixes this, but only for gh pr view. This PR fixes gh issue view in addition.

Copy link
Copy Markdown
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for adding these back in.

@samcoe samcoe merged commit 4c53e5e into cli:trunk Jan 4, 2021
@camelid camelid deleted the view-newline branch January 4, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh issue view output misses a trailing line break. gh pr view doesn't print a newline after the URL

4 participants

X Tutup