Document that reviewers can be teams#2465
Merged
Conversation
mislav
suggested changes
Nov 24, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thanks for working on this! 🎉
Co-authored-by: Mislav Marohnić <hi@mislav.net>
MaxHorstmann
changed the title
Contributor
Author
|
@mislav thanks for the quick response! I addressed all your comments. |
mislav
approved these changes
Nov 26, 2020
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I don't see any updates on gh pr create yet - does this need to get deployed to production? |
Contributor
|
@MaxHorstmann The documentation site will be automatically re-generated with the next release. We don't re-generate the site from |
Contributor
Author
|
Thanks for the clarification!
…On Tue, Dec 1, 2020, 6:49 AM Mislav Marohnić ***@***.***> wrote:
@MaxHorstmann <https://github.com/MaxHorstmann> The documentation site
will be automatically re-generated with the next release.
We don't re-generate the site from trunk between releases because we want
to avoid accidentally publishing docs for un-released features.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2465 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACSEP6OPAWPNMR6CQM2JE3SSTJ5VANCNFSM4UACTZ2A>
.
|
mislav
added a commit
that referenced
this pull request
Dec 2, 2020
Co-authored-by: Mislav Marohnić <mislav@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took me a while to figure out that when creating a PR via gh pr create, reviewers
and assigneescan be both individual users and also entire teams (confirmed in source).This is a little different from the equivalent API endpoint, which has separate parameters
reviewersandteam_reviewers.PR just seeks to document this a little better.
Releated Stack Overflow question