Better sorting and freshness display for issue status#237
Merged
Conversation
ampinsk
approved these changes
Jan 17, 2020
ampinsk
left a comment
ampinsk
left a comment
There was a problem hiding this comment.
Looks great from a design perspective!
mislav
approved these changes
Jan 20, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Looks great, especially the test! 🚀
utils/utils.go
Outdated
| return fmt.Sprintf("about %s ago", Pluralize(int(ago.Hours()), "hour")) | ||
| } | ||
|
|
||
| return fmt.Sprintf("about %s ago", Pluralize(int(ago.Hours()/24), "day")) |
Contributor
There was a problem hiding this comment.
The fallback is to use "about N days" ago, but when this turns into months or years (some issues can be open for a really long time), it could display large numbers like “234 days ago", which could be difficult to interpret for a human.
If it's less than a year, but more than 30 days, can we show "months" and otherwise "years"?
mislav
pushed a commit
that referenced
this pull request
Jan 23, 2020
Better sorting and freshness display for issue status
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
* Use deployment environment gating for integration tests. * Only run on PRs that target main. * Use correct head name.
cchristous
pushed a commit
to cchristous/cli
that referenced
this pull request
Feb 28, 2026
* feat: list all projects using pagination in v1alpha/projects * feat(projects): use retry with exponential backoff * ci: gen test results report * fix(projects): use only get projects, drop page_size query param. * chore: pin gotestsum to the latest working version v1.12.2 * fix: simplify the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
This PR:
issue statusto sort byupdatedAtinstead ofcreatedAtNB:
updatedAtcoversthe GraphQL docs are fully opaque on that and I had to test it out myself to figure that out.
I didn't update the tests for
issue statusbut I did add unit tests for the fuzzy logic.