X Tutup
Skip to content

Support for --web when using gist create#2263

Merged
vilmibm merged 3 commits intocli:trunkfrom
cesoun:gist-web-support
Nov 16, 2020
Merged

Support for --web when using gist create#2263
vilmibm merged 3 commits intocli:trunkfrom
cesoun:gist-web-support

Conversation

@cesoun
Copy link
Copy Markdown
Contributor

@cesoun cesoun commented Oct 23, 2020

Proposal to close #2071

Added support for gh gist create [<filename>... | -] --web
Added test to gist/create/create_test.go for --web argument

Thought it would be fun and took a stab at it.

Proposal to close cli#2071

I have not worked with Go prior to this so please smite me down with the
wisdom of a million Golang gods if I'm doing something terribly wrong.

I also added a test to gist/create for the added web arg.

Pretty much referenced the implementation from pr/create.
I believe this fixes it as it stopped failing on a local vm. Otherwise I
will try and tackle it tomorrow.
@vilmibm vilmibm self-requested a review November 16, 2020 21:48
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vilmibm vilmibm merged commit 0bb44c9 into cli:trunk Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supply --web to gist create to streamline create & view process

3 participants

X Tutup