Filter out unwanted stderr output during git push commands#2016
Merged
Filter out unwanted stderr output during git push commands#2016
Conversation
samcoe
force-pushed
the
filter-git-push-output
branch
6 times, most recently
from
1a414cf to
a90a9a0
Compare
samcoe
changed the title
samcoe
force-pushed
the
filter-git-push-output
branch
from
a90a9a0 to
4100857
Compare
samcoe
commented
Sep 30, 2020
samcoe
commented
Sep 30, 2020
samcoe
commented
Sep 30, 2020
mislav
suggested changes
Sep 30, 2020
samcoe
force-pushed
the
filter-git-push-output
branch
from
4100857 to
c138964
Compare
samcoe
force-pushed
the
filter-git-push-output
branch
from
514b202 to
e30be98
Compare
mislav
previously requested changes
Oct 1, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
This is progressing great! I would suggest focusing on ironing out the RegexWriter so it doesn't inadvertently change the output that wasn't related to "Create a pull request", such as the progress indicator from git push.
samcoe
force-pushed
the
filter-git-push-output
branch
2 times, most recently
from
b44ce6d to
901ac02
Compare
cbraynor
reviewed
Oct 12, 2020
samcoe
force-pushed
the
filter-git-push-output
branch
5 times, most recently
from
fb7b594 to
b1672d8
Compare
vilmibm
approved these changes
Nov 2, 2020
Contributor
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
I'm into this 👍 sam had expressed concern about it being over-complex and perhaps for this single use case it is, but once it exists I definitely see us reaching for it more to handle git output.
I'd like to have it in; and it's easy to remove and do something simpler if we decide we want that.
vilmibm
dismissed
mislav’s stale review
the feedback was addressed and mislav is OOO
samcoe
force-pushed
the
filter-git-push-output
branch
from
b1672d8 to
9acbf8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a wrapper around an
io.Writertype that will filter the output based on a regex and replace matches with a replacement string, and finally write the filtered output to the originalio.Writer.closes #1067