Conversation
| } | ||
|
|
||
| flagUsages := command.LocalFlags().FlagUsages() | ||
| flagUsages := command.Flags().FlagUsages() |
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
thank you!!
I really like the --verbose idea; I don't think I want that to go away, but I would still like information about environment variables in gh help env
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Nice work, @samcoe!
Transferring conclusions we've made in chat to here: although I generally like the idea of a command that helps user debug their environment and their setup, I think this PR as of right now loses sight of the issue #1384 it was supposed to address: to extract documentation about environment variables to its own help page. In this branch, running gh help env does not print information about available environment variables, and so this information wouldn't make it to man pages on our website either.
I definitely want us to explore making a runnable command for the purpose of debugging, but I would suggest that it's ideally done separately after we've already addressed the documentation bit.
For now, we could still go the route of creating a separate command, possibly marking it as "hidden" too and making it non-runnable for now.
|
Closing in favor of #1696 |
3 participants
This PR adds an
envcommand that displays current environment variable values that GH uses. Adding the--verboseflag will output a desription of how each of the environment variables is used.closes #1384