X Tutup
Skip to content

refactor: repo cmd#1161

Closed
gedenata wants to merge 3 commits intocli:trunkfrom
gedenata:develop
Closed

refactor: repo cmd#1161
gedenata wants to merge 3 commits intocli:trunkfrom
gedenata:develop

Conversation

@gedenata
Copy link
Copy Markdown
Contributor

No description provided.

@AliabbasMerchant
Copy link
Copy Markdown
Contributor

I fully support this PR, but @gedenata have a look at this: #951

@mislav
Copy link
Copy Markdown
Contributor

mislav commented Jun 11, 2020

@gedenata Thank you for trying to help improve our codebase!

We do plan to move commands into separate packages; see pkg/cmd/api/ for the latest example. However, the migration will inevitably involve changing more things than just moving the code around and exporting reusable functions. As such, I think it's best that our team handle the refactoring style of work, and contributors like you help us out with bug fixes and adding features when those are discussed/approved. Thank you!

@mislav mislav closed this Jun 11, 2020
@gedenata gedenata deleted the develop branch June 11, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup