X Tutup
Skip to content

Fix secret command panic when base repo from cwd#10549

Merged
williammartin merged 1 commit intotrunkfrom
10548-v2680-failed-to-run-secret-commands
Mar 6, 2025
Merged

Fix secret command panic when base repo from cwd#10549
williammartin merged 1 commit intotrunkfrom
10548-v2680-failed-to-run-secret-commands

Conversation

@williammartin
Copy link
Member

@williammartin williammartin commented Mar 6, 2025

Description

Fixes #10548

The bug was introduced by #10539.

@williammartin williammartin requested a review from a team as a code owner March 6, 2025 10:45
@williammartin williammartin requested a review from BagToad March 6, 2025 10:45
@williammartin williammartin linked an issue Mar 6, 2025 that may be closed by this pull request
@williammartin
Copy link
Member Author

williammartin commented Mar 6, 2025

I paired on this with @SamMorrowDrums, and I'm going to bypass the code review requirement in order to release.

@williammartin williammartin merged commit fc19ff3 into trunk Mar 6, 2025
17 checks passed
@williammartin williammartin deleted the 10548-v2680-failed-to-run-secret-commands branch March 6, 2025 11:01
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 7, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | patch | `v2.68.0` -> `v2.68.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.68.1`](https://github.com/cli/cli/releases/tag/v2.68.1): GitHub CLI 2.68.1

[Compare Source](cli/cli@v2.68.0...v2.68.1)

#### What's Changed

-   Fix secret command panic when base repo is determined via cwd by [@&#8203;williammartin](https://github.com/williammartin) in cli/cli#10549

**Full Changelog**: cli/cli@v2.68.0...v2.68.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODguMyIsInVwZGF0ZWRJblZlciI6IjM5LjE4OC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
@SIMPLEXITYFUB

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.68.0 failed to run secret commands

2 participants

X Tutup