fix: Normalize URL before executing HTTP request#13674
Open
akylkb wants to merge 1 commit intochatwoot:developfrom
Open
fix: Normalize URL before executing HTTP request#13674akylkb wants to merge 1 commit intochatwoot:developfrom
akylkb wants to merge 1 commit intochatwoot:developfrom
Conversation
Support for Unicode characters, such as Cyrillic
akylkb
changed the title
Contributor
|
Hi, I reviewed this PR and noticed that the case it's trying to solve is already covered in the current codebase.
The only scenario where Unicode could appear in the final URL would be through Liquid templates (when the LLM injects values into path segments), but that's already handled by the Could you maybe share a concrete use case where this actually fails? That way we can better understand if there's a scenario I'm not considering. CC: aakashb95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Unicode characters, such as Cyrillic