fix(config): do not error on unmatched ignore patterns#1885
fix(config): do not error on unmatched ignore patterns#1885mixelburg wants to merge 1 commit intochangesets:mainfrom
Conversation
Previously, listing a package name or glob expression in the 'ignore' config option that did not match any workspace package would throw a validation error. This made it impossible to use ignore patterns for packages that may not always be present (e.g. dynamically generated packages, conditionally-installed packages, or future packages not yet created). This change removes the unmatched-pattern validation specifically for the 'ignore' option. Unlike 'fixed' and 'linked' groups -- where all packages must exist to form a valid constraint group -- ignoring a non-existent package is a safe no-op: the pattern simply matches nothing and has no effect on the release plan. Fixes changesets#1794
|
|
why we'd only do this for |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 81.84% 81.82% -0.03%
==========================================
Files 55 55
Lines 2396 2393 -3
Branches 725 723 -2
==========================================
- Hits 1961 1958 -3
Misses 429 429
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem
When specifying a package name or glob expression in the
ignoreconfig option that doesn't match any workspace package, changesets throws a validation error:This makes it impossible to use
ignorepatterns for packages that may not always be present, such as:prisma generate)Solution
Remove the unmatched-pattern validation for the
ignoreoption. Unlikefixedandlinkedgroups — where all packages must exist to form a valid constraint group — ignoring a non-existent package is a safe no-op: the pattern simply matches nothing and has no effect on the release plan.The
fixedandlinkedgroup validations are unchanged, since those do require all referenced packages to exist.Changes
@changesets/configignorearrayRelated
Closes #1794