X Tutup
Skip to content

Mypy types for completion#928

Merged
thomasballinger merged 2 commits intomainfrom
mypy-types
Oct 7, 2021
Merged

Mypy types for completion#928
thomasballinger merged 2 commits intomainfrom
mypy-types

Conversation

@thomasballinger
Copy link
Copy Markdown
Member

@thomasballinger thomasballinger commented Oct 7, 2021

We're not checking these in CI nor are we providing a config file yet.
I used mypy 0.910 run directly on bpython/autocomplete.py and still had 3 errors after these changes.

We're not checking these in CI nor are we providing a config file yet.
I used mypy 0.910 run directly on bpython/autocomplete.py and still had
4 errors after these changes.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #928 (8da0381) into main (78ead4c) will decrease coverage by 0.23%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   67.99%   67.75%   -0.24%     
==========================================
  Files          61       61              
  Lines        9187     9187              
==========================================
- Hits         6247     6225      -22     
- Misses       2940     2962      +22     
Impacted Files Coverage Δ
bpython/autocomplete.py 86.56% <90.90%> (+0.89%) ⬆️
bpython/test/test_interpreter.py 75.86% <0.00%> (-6.90%) ⬇️
bpython/test/test_keys.py 88.09% <0.00%> (-4.77%) ⬇️
bpython/simpleeval.py 89.39% <0.00%> (-4.55%) ⬇️
bpython/test/fodder/original.py 57.14% <0.00%> (-3.73%) ⬇️
bpython/test/fodder/processed.py 57.14% <0.00%> (-3.73%) ⬇️
bpython/curtsiesfrontend/parse.py 86.79% <0.00%> (-1.89%) ⬇️
bpython/test/test_simpleeval.py 93.81% <0.00%> (-1.04%) ⬇️
bpython/inspection.py 82.92% <0.00%> (-0.98%) ⬇️
bpython/curtsiesfrontend/coderunner.py 79.81% <0.00%> (-0.92%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ead4c...8da0381. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup