X Tutup
Skip to content

Fixing Windows Python2 compatibility#601

Merged
sebastinas merged 1 commit intobpython:masterfrom
adityagupta679:patch-1
Feb 18, 2016
Merged

Fixing Windows Python2 compatibility#601
sebastinas merged 1 commit intobpython:masterfrom
adityagupta679:patch-1

Conversation

@adityagupta679
Copy link
Copy Markdown

It breaks the code when using on windows python2

unsupported operand type | 'list' and 'list': python 2.7

unsupported operand type | list and list: python 2.7
@thomasballinger
Copy link
Copy Markdown
Member

Introduced by #597

I don't know how big the Windows userbase is but this is probably enough to prompt a 15.1 soon.

@adityagupta679
Copy link
Copy Markdown
Author

Yes , also while we are on it , I think we need to modify the "contributing" documentation for windows developers .

@thomasballinger
Copy link
Copy Markdown
Member

Cool, a separate PR for that would be great.

@adityagupta679
Copy link
Copy Markdown
Author

I will get to it . I guess i will have to modify the contributing.rst file .

sebastinas added a commit that referenced this pull request Feb 18, 2016
Fixing Windows Python2 compatibility
@sebastinas sebastinas merged commit b50250a into bpython:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup