Merged
Conversation
…e traceback method to send to standard error.
Member
|
This works for me, have you tried it with Python3? Two comments for making the code easier to maintain in the future:could you add a testfor this (so we catch Python 2/3 problems automatically) and factor out the portions common to both the traceback and syntax error methods? (So we don't mess up by changing one but not the other, except for things that are different between them) This reminds me of needing to get make sure future statements work alright with this interpreter, but that's not your problem - just a reminder for me because the old bpython interactive interpreter is doing fancier things than we do in bpython curtsies. |
Contributor
Author
|
I haven't run into any problems using it with python 3. I'll make those other changes. |
d155aaf to
ec8a32e
Compare
Member
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some helpful highlighting to traceback and error messages rather than just printing a wall of red text.