Display tuple unpacking in argspec correctly.

Trundle · Trundle · commit 7bb3b4aa3224 · 2010-08-25T21:15:39.000+02:00
This closes issue #138.
diff --git a/bpython/cli.py b/bpython/cli.py
@@ -66,6 +66,9 @@ def log(x):
     f.write('%s\n' % (x,))
 
 py3 = sys.version_info[0] == 3
+if not py3:
+    import inspect
+
 stdscr = None
 
 def getpreferredencoding():
@@ -673,7 +676,13 @@ def mkargspec(self, topline, down):
             if k == in_arg or i == in_arg:
                 color |= curses.A_BOLD
 
-            self.list_win.addstr(str(i), color)
+            if not py3:
+                # See issue #138: We need to format tuple unpacking correctly
+                # We use the undocumented function inspection.strseq() for
+                # that. Fortunately, that madness is gone in Python 3.
+                self.list_win.addstr(inspect.strseq(i, str), color)
+            else:
+                self.list_win.addstr(str(i), color)
             if kw:
                 self.list_win.addstr('=', punctuation_colpair)
                 self.list_win.addstr(kw, get_colpair(self.config, 'token'))
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -588,7 +588,7 @@ def complete(self, tab=False):
 
         if not e and self.argspec:
             matches.extend(name + '=' for name in self.argspec[1][0]
-                           if name.startswith(cw))
+                           if isinstance(name, basestring) and name.startswith(cw))
             if py3:
                 matches.extend(name + '=' for name in self.argspec[1][4]
                                if name.startswith(cw))
diff --git a/bpython/urwid.py b/bpython/urwid.py
@@ -51,6 +51,8 @@
 import urwid
 
 py3 = sys.version_info[0] == 3
+if not py3:
+    import inspect
 
 Parenthesis = Token.Punctuation.Parenthesis
 
@@ -536,7 +538,13 @@ def _populate_completion(self):
                     if k == in_arg or i == in_arg:
                         color = 'bold ' + color
 
-                    markup.append((color, str(i)))
+                    if not py3:
+                        # See issue #138: We need to format tuple unpacking correctly
+                        # We use the undocumented function inspection.strseq() for
+                        # that. Fortunately, that madness is gone in Python 3.
+                        markup.append((color, inspect.strseq(i, str)))
+                    else:
+                        markup.append((color, str(i)))
                     if kw:
                         markup.extend([('punctuation', '='),
                                        ('token', kw)])
