Add type check instead of using exceptions

sebastinas · sebastinas · commit 2dd27f9eacf8 · 2022-02-03T23:04:09.000+01:00
diff --git a/bpython/patch_linecache.py b/bpython/patch_linecache.py
@@ -53,10 +53,10 @@ def __delitem__(self, key):
             return super().__delitem__(key)
 
 
-def _bpython_clear_linecache():
-    try:
+def _bpython_clear_linecache() -> None:
+    if isinstance(linecache.cache, BPythonLinecache):
         bpython_history = linecache.cache.bpython_history
-    except AttributeError:
+    else:
         bpython_history = []
     linecache.cache = BPythonLinecache()
     linecache.cache.bpython_history = bpython_history
@@ -68,12 +68,12 @@ def _bpython_clear_linecache():
 linecache.clearcache = _bpython_clear_linecache
 
 
-def filename_for_console_input(code_string):
+def filename_for_console_input(code_string: str) -> str:
     """Remembers a string of source code, and returns
     a fake filename to use to retrieve it later."""
-    try:
+    if isinstance(linecache.cache, BPythonLinecache):
         return linecache.cache.remember_bpython_input(code_string)
-    except AttributeError:
+    else:
         # If someone else has patched linecache.cache, better for code to
         # simply be unavailable to inspect.getsource() than to raise
         # an exception.
