Show deprecation warnings for urwid/curses/python2.

ikanobori · ikanobori · commit 08c490f1d6fa · 2020-01-05T10:59:01.000Z
diff --git a/CHANGELOG b/CHANGELOG
@@ -4,6 +4,13 @@ Changelog
 0.19
 ----
 
+General information:
+* The bpython-cli and bpython-urwid rendering backends have been deprecated and
+  will show a warning that they'll be removed in a future release when started.
+* Usage in combination with Python 2 has been deprecated. This does not mean that
+  support is dropped instantly but rather that at some point in the future we will
+  stop running our testcases against Python 2.
+
 New features:
 
 Fixes:
diff --git a/bpython/cli.py b/bpython/cli.py
@@ -1988,6 +1988,16 @@ def main_curses(scr, args, config, interactive=True, locals_=None, banner=None):
     if banner is not None:
         clirepl.write(banner)
         clirepl.write("\n")
+
+    # XXX these deprecation warnings need to go at some point
+    clirepl.write("WARNING: You are using `bpython-cli`, the curses backend for `bpython`. This backend has been deprecated in version 0.19 and might disappear in a future version.")
+    clirepl.write("\n")
+
+    if sys.version_info[0] == 2:
+        # XXX these deprecation warnings need to go at some point
+        clirepl.write("WARNING: You are using `bpython` on Python 2. Support for Python 2 has been deprecated in version 0.19 and might disappear in a future version.")
+        clirepl.write("\n")
+
     exit_value = clirepl.repl()
     if hasattr(sys, "exitfunc"):
         sys.exitfunc()
diff --git a/bpython/curtsies.py b/bpython/curtsies.py
@@ -201,6 +201,11 @@ def main(args=None, locals_=None, banner=None, welcome_message=None):
         print(bpargs.version_banner())
     if banner is not None:
         print(banner)
+
+    if sys.version_info[0] == 2:
+        # XXX these deprecation warnings need to go at some point
+        print("WARNING: You are using `bpython` on Python 2. Support for Python 2 has been deprecated in version 0.19 and might disappear in a future version.")
+
     global repl
     repl = FullCurtsiesRepl(config, locals_, welcome_message, interp)
     try:
diff --git a/bpython/urwid.py b/bpython/urwid.py
@@ -1390,6 +1390,16 @@ def start(main_loop, user_data):
         if banner is not None:
             myrepl.write(banner)
             myrepl.write("\n")
+
+        # XXX these deprecation warnings need to go at some point
+        myrepl.write("WARNING: You are using `bpython-urwid`, the urwid backend for `bpython`. This backend has been deprecated in version 0.19 and might disappear in a future version.")
+        myrepl.write("\n")
+
+        if sys.version_info[0] == 2:
+            # XXX these deprecation warnings need to go at some point
+            myrepl.write("WARNING: You are using `bpython` on Python 2. Support for Python 2 has been deprecated in version 0.19 and might disappear in a future version.")
+            myrepl.write("\n")
+
         myrepl.start()
 
         # This bypasses main_loop.set_alarm_in because we must *not*
