Fix 969 Update SCOP version to 2.08#972
Merged
josemduarte merged 1 commit intobiojava:masterfrom Sep 27, 2021
Merged
Conversation
All SCOP installation file downloads fail because all files before 2.08 no longer exist (error 404). 1- All downloads are corrected by upgrading the LATEST_VERSION to 2.08. 2- testGetStructureForChainlessDomains is ignored because chainless domains are present only in SCOP < 1.73
Member
Author
|
Fix for #969 |
aalhossary
changed the title
josemduarte
approved these changes
Sep 27, 2021
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing! LGTM
Contributor
|
I'll merge this. I've tested locally and it passes all tests. I'll also remove an obsolete scop test that was using some old http endpoint that is now gone. I'll push that directly to master. |
aalhossary
deleted the
Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969
branch
aalhossary
restored the
Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969
branch
Member
Author
|
I restored one previously ignored test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All SCOP installation file downloads fail because all files before 2.08
no longer exist (error 404).
1- All downloads are corrected by upgrading the LATEST_VERSION to 2.08.
2- testGetStructureForChainlessDomains is ignored because chainless
domains are present only in SCOP < 1.73