Fixing issue with Calc.transform(Chain,Matrix4d)#716
Merged
josemduarte merged 4 commits intobiojava:masterfrom Dec 12, 2017
Merged
Fixing issue with Calc.transform(Chain,Matrix4d)#716josemduarte merged 4 commits intobiojava:masterfrom
josemduarte merged 4 commits intobiojava:masterfrom
Conversation
josemduarte
added a commit
to josemduarte/biojava
that referenced
this pull request
Dec 8, 2017
lafita
approved these changes
Dec 9, 2017
Member
lafita
left a comment
lafita
left a comment
There was a problem hiding this comment.
It looks great! I only have one minor suggestion!
|
|
||
| } | ||
| for (Group altG : group.getAltLocs()) { | ||
| for (Atom atom : altG.getAtoms()) { |
Member
There was a problem hiding this comment.
Why not using translate(g, v)? It would be a recursive call to this function, nicer solution.
lafita
approved these changes
Dec 9, 2017
|
|
||
| } | ||
| for (Group altG : group.getAltLocs()) { | ||
| for (Atom atom : altG.getAtoms()) { |
Member
There was a problem hiding this comment.
Recursive call to transform(g, m) could also be possible here.
Contributor
Author
There was a problem hiding this comment.
Good point, now changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #715