code style & formatters#3
Merged
brandstaetter merged 11 commits intobiojava:develfrom Apr 12, 2013
brandstaetter:devel
Merged
Conversation
Added some code style suggestions and a short document detailing the setup on eclipse Signed-off-by: Hannes Brandstätter-Müller <hannes.mueller@gmail.com>
Added some code style suggestions and a short document detailing the setup on eclipse Signed-off-by: Hannes Brandstätter-Müller <hannes.mueller@gmail.com>
changed indentation to 4 spaces for java and added hint how to configure XML formatting Signed-off-by: brandstaetter <hannes.mueller@gmail.com>
Member
Author
|
I will merge this on Friday, unless there are any vetoes/votes against. |
Member
|
+1 to merging this pull request. -0 to reformatting all existing files. I think it is good to use the formatter and related settings going forward, but I don't want to see all per-line revision history being lost (when using e.g. svn blame or Team --> Show Annotation in Eclipse). |
aalhossary
added a commit
that referenced
this pull request
Apr 27, 2013
emckee2006
added a commit
that referenced
this pull request
Nov 28, 2013
Catch back up with biojava/master
josemduarte
pushed a commit
that referenced
this pull request
Apr 6, 2016
Solving conflict and merging master in
andreasprlic
pushed a commit
that referenced
this pull request
Aug 4, 2016
Added some docs from Peter's original
altaite
pushed a commit
that referenced
this pull request
Mar 29, 2017
adding a parsing performance unit test for mmtf, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for code style and eclipse formatters. Please discuss.
I also would suggest to reformat all existing java (and xml) files, since we just had the code freeze and not too many new developments should be affected.