Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60899 |
JLHwung
force-pushed
the
eslint-10-support
branch
from
f3628a9 to
6809a4d
Compare
|
commit: |
JLHwung
force-pushed
the
eslint-10-support
branch
from
63ecf91 to
6809a4d
Compare
Member
|
Should we also backport this? I imagine that upgrading ESLint and Babel at the same time for users would be quite a big step. |
Member
It seems that |
liuxingbaoyu
approved these changes
Feb 14, 2026
nicolo-ribaudo
approved these changes
Feb 15, 2026
nicolo-ribaudo
added
the
PR: Bug Fix (next major) 🐛
This was referenced Feb 15, 2026
This was referenced Feb 17, 2026
This was referenced Feb 19, 2026
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the only breaking change that I can observe is that ESTree now handles the range of
Programnode as same as we do, i.e. start the program at the start of the first leading comments of a program. This is nice as we can further remove logics from the convert layer when we drop ESLint 9 support.However, the TSESLint parser still do it in the ESLint 9 fashion, so we have to copy the location adjustment logic to the integration test files.
This PR also add an ESLint 9 test job, mostly copied from the removed files in #17766.