X Tutup
Skip to content

Better error message from JSInterop when detecting an unconfigured module import#425

Merged
egil merged 15 commits intobUnit-dev:mainfrom
jgoday:jsinterop_error_msg
Jun 23, 2021
Merged

Better error message from JSInterop when detecting an unconfigured module import#425
egil merged 15 commits intobUnit-dev:mainfrom
jgoday:jsinterop_error_msg

Conversation

@jgoday
Copy link
Contributor

@jgoday jgoday commented Jun 11, 2021

Pull request description

Fixes #398.
Personalize JSInterop error message when trying to import an unconfigured module.

PR meta checklist

  • Pull request is targeted at main branch for code
    or targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@jgoday jgoday mentioned this pull request Jun 11, 2021
Closed
@egil
Copy link
Member

egil commented Jun 14, 2021

Thanks for this. Ill take a look today, its been a very busy weekend.

@egil egil merged commit bd0cfb1 into bUnit-dev:main Jun 23, 2021
@egil
Copy link
Member

egil commented Jun 23, 2021

Great work @jgoday. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egil egil egil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better error message from JSInterop when detecting an unconfigured module import

2 participants

@jgoday @egil
X Tutup