Conversation
…thod Replace deprecated assertThat method in tests
Remove apiDiff check for v4 development
* [SDK-3150] Serialize dates in collections as seconds since epoch * cleanup tests * Update javadocs
* Added Gradle Tasks to run tests on Java LTS versions * Ignore secp256k1 curve tests * Removing ignore for tests and checking the CI failure * Exclude secp256k1 Tests for Java 17 * Remove unwanted "ignore" imports
* [SDK-3149] Add support for java.time.Instant * formatting fixes * add javadocs * remove custom Instant claim verification check (not yet supported) * add tests for default method implementations * fix NullClaimTest for asInstant
* [SDK-3186] Support date/time custom claim validation * Add tests for Verification default method implementations * add tests for null expected claim handling * updated javadoc per code review suggestion
* Bump `jackson-databind` dependency to 2.13.2 (#542) * Bump `jackson-databind` dependency to 2.13 * Update build.gradle * Update build.gradle * Deprecate ES256K Algorithm (#543) * [SDK-3192] Deprecate secp256k1 curve for EC Algorithms * Documentation update * Release 3.19.0 Co-authored-by: Evan Sims <evan.sims@auth0.com> Co-authored-by: James Anderson <jim.anderson@auth0.com>
* [SDK-3171] Fix header claims serialization * remove debug line
* Remove ES256K methods and related tests * Removed related files and constants
* Add lint checks * Cleaned up lint errors * Add rule to avoid println in code * Remove unused methods in CryptoHelper
* Rename claims -> expectedClaims in verifier for clarity * added method to validate claim value using predicate * Using Predicates for Verification (#560) * Use predicates for verification * Code review changes * Add additional tests for predicate based verification * Fixed Lint issues
* Handle claim difference between missing and null * Verification with null claims * JWT creation support for null values * Test cases for JWT verification and construction * Add JWT decode test cases * Fix broken tests * Fixed Lint issues * Fixed formatting errors * Add test case to check Claim toString conversion
* Improved exception handling * Fixed issues thrown by Linter * Fixed Lint Issue (Missing Period) * Improved Code Coverage
* Replace expected exception with assertThrows
* Added support for multiple checks on a single claim * Fix codecov CI failure * Allow pseudo comparison for codecov * Remove newly added parameters and check codecov disabled * Reenabled changes check in codecov * Trigger Build * Refactor ExpectedCheckHolder from interfaces to impl package * Refactored code to improve coverage report
[SDK-3226] Expose claim header constants
This PR updates the CircleCI workflow for v4 to add Semgrep automated security testing to the continuous integration tests.
Add Semgrep to continuous integration tests
Improved README structure
[SDK-3159] JavaDoc updated
[SDK-3244] Add Migration Guide
Documentation updates
[SDK-3125] Updated documentation regarding HMAC Key length
Update from master to v4
|
@poovamraj this has all been peer-reviewed as it went along right? Anything specific we need to take a look at here? |
Added tests to verify null creation in list and map
Contributor
Author
|
@stevehobbsdev Everything should be good, as you mentioned all of them are peer reviewed. We should be good to go. |
stevehobbsdev
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we will be merging the changes we have done for v4 into the master. All the changes for v4 can be found in the Milestone here - https://github.com/auth0/java-jwt/milestone/33