Conversation
poovamraj
force-pushed
the
update-java-docs
branch
from
1046401 to
e6565ce
Compare
poovamraj
added
documentation
Contributor
Author
|
Project coverage has decreased by 0.01% since we removed |
jimmyjames
reviewed
Apr 20, 2022
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Looks great - I left a comment regarding your TODO. Once we address that, this is good to go 👍
| * <p> | ||
| * This class is thread-safe. | ||
| * | ||
| * TODO Poovam - Should we claim thread safety since KeyProvider implementation can cause signing differ |
Contributor
There was a problem hiding this comment.
Do you mean that an implementation of KeyProvider may not be thread-safe, rendering this class not thread-safe? If so, we can claim thread safety of this class, and also document that implementations of KeyProvider must be thread-safe.
|
|
||
| /** | ||
| * The "jti" (JWT ID) claim provides a unique identifier for the JWT. | ||
| * Refer RFC 7529 <a href="https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.7">Section 4.1.7</a> |
| default Verification withAnyOfAudience(String... audience) { | ||
| throw new UnsupportedOperationException("withAnyOfAudience"); | ||
| } | ||
| Verification withAnyOfAudience(String... audience); |
Contributor
There was a problem hiding this comment.
👍 thanks for removing the default implementation
jimmyjames
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We have updated the Java doc with relevant information and made a few required changes.
This includes