Conversation
bf5b476 to
8ad09b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Before this code removes the check for
claimwith123After the code checks for claim to have value
123and then checks for valuenullBefore this code overrides the check for
claimwithcheck1tocheck2After the code checks for
claimto have valuecheck1andcheck2Before this code doesn't check for the
claimvalueAfter the code checks for
claimto havenullReferences
#558
Testing
We have added tests to ensure null values are checked properly in the claim
We have tested that multiple claim checks are added
Improved branch coverage to ~98%
This change adds test coverage
This change has been tested on the latest version of Java or why not