Conversation
jimmyjames
suggested changes
Apr 5, 2022
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Let's also update the info about the available methods on the Claim types as needed, as well as review and update any docs regarding Date-based claim values to demonstrate Instant support, while we're here.
jimmyjames
approved these changes
Apr 19, 2022
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
👍 Looks good. I'll make another pass through the README for any additional improvement oppoortunities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note - need to review KeyProvider section based on the decision of #570
Changes
Restructured README in a more a consumable way
Added table of content
References
Refered to Auth0.Swift and nextjs-auth0 README
Testing
Checked the Preview for Markdown formatting