X Tutup
Skip to content

[SDK-3149] Add Instant support#537

Merged
jimmyjames merged 6 commits intov4-devfrom
add-instant-support
Mar 9, 2022
Merged

[SDK-3149] Add Instant support#537
jimmyjames merged 6 commits intov4-devfrom
add-instant-support

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

🕐 Adds support for java.time.Instant 🕐

This PR adds support for java.time.Instant for creating and verifying JWTs. Key points to note:

  • Instant support is added to Date functionality; customers using Date can continue to do so.
  • Additional methods added to interfaces have a default implementation using the underlying Date methods
  • Internal implementation updated to use Instant for its improved functionality

Note: This PR does not include support for custom claim validation of type Instant. A separate PR will add support for this as well as address the current issue of Date-based claim validation not accounting for date/time claims being serialized as seconds since the epoch.

References

https://docs.oracle.com/javase/8/docs/api/java/time/Instant.html

Testing

Existing unit tests provide good coverage, and tests added for new methods

@jimmyjames jimmyjames added this to the v4-Beta milestone Mar 7, 2022
@jimmyjames jimmyjames requested a review from a team as a code owner March 7, 2022 04:50
@jimmyjames jimmyjames changed the title Add instant support [SDK-3149] Add instant support Mar 7, 2022
@jimmyjames jimmyjames force-pushed the add-instant-support branch from 0f670fb to 4e95a93 Compare March 7, 2022 16:35
@jimmyjames jimmyjames changed the title [SDK-3149] Add instant support [SDK-3149] Add Instant support Mar 7, 2022
Copy link
Copy Markdown
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jimmyjames jimmyjames merged commit 90cea2d into v4-dev Mar 9, 2022
@jimmyjames jimmyjames deleted the add-instant-support branch March 9, 2022 20:27
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup