Added additional conditions on varargs to make sure given varargs or …#405
Closed
ssrm wants to merge 5 commits intoauth0:masterfrom
Closed
Added additional conditions on varargs to make sure given varargs or …#405ssrm wants to merge 5 commits intoauth0:masterfrom
ssrm wants to merge 5 commits intoauth0:masterfrom
Conversation
jimmyjames
suggested changes
Mar 18, 2020
| } | ||
| boolean isAllNull = true; | ||
| for (String arg: args) { | ||
| if (arg != null && arg.trim().length() != 0) { |
Contributor
There was a problem hiding this comment.
Let's not check for empty strings here, just null. That will be consistent with how we handle empty strings for other claims.
jimmyjames
added
small
4 tasks
Contributor
|
I've taken the basis of this PR with another PR that is similar, except it does allow empty string values. #412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…not null
Changes
Please describe both what is changing and why this is important. Include:
If there is no aud/iss field in token, its a breaking change for the apps. In my case, we do not maintain audience field in token. Let me know if this is ok.
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist