Remove unnecessary cast between long/double and floor call#296
Merged
lbalmaceda merged 1 commit intoauth0:masterfrom Oct 30, 2018
Merged
Remove unnecessary cast between long/double and floor call#296lbalmaceda merged 1 commit intoauth0:masterfrom
lbalmaceda merged 1 commit intoauth0:masterfrom
Conversation
Calculating `time / 1000 * 1000` already returns the correctly truncated result using long arithmetic
Contributor
|
I think this was originally added either because the JDK7 compiler complained or because tests were randomly failing because of that +/- second change in the verification. |
Contributor
Author
|
I could not find the historical commit that introduced the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculating
time / 1000 * 1000already returns the correctly truncated result using long arithmetic