Support multiple issuers #246#288
Support multiple issuers #246#288lbalmaceda merged 10 commits intoauth0:masterfrom itdevelopmentapps:master
Conversation
lbalmaceda
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay. I've left you some comments. Please remember to rebase the branch.
lbalmaceda
left a comment
There was a problem hiding this comment.
Sorry for the confusion. I've left a few changes I need you to accept before merging this.
|
@itdevelopmentapps are you still interesting in merging this PR? Please, don't hesitate to ask any questions. |
|
@lbalmaceda please advise in what test you would like to see to increase coverage so that we can get this pull request accepted. |
|
By checking the coverage report, there are 2 missing branches.
I hope that's clear enough. It should help make the check green. |
|
@lbalmaceda we've added the suggested tests. |
|
Thank you. Will release before eow. |
|
Many thanks. |
|
Using Clojure this was a breaking change, got the following error: When trying to call (.withIssuer Verification "example")After (.withIssuer Verification (into-array String ["example])) |
Added support for multiple issuers.
I wanted to change the previous pull request so I closed it, maybe if you guys can remove that one in favor for this one.
Many thanks.