Instantiate exception only when required#198
Merged
lbalmaceda merged 1 commit intoauth0:masterfrom Aug 29, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
convertFromJSON()method in theJWTParserclass instantiates an exception (which is accompanied by an invocation of the somewhat expensiveString.format()method) for every JSON string to be converted. This occurs even if the given JSON string is valid and the exception will never be thrown. As theconvertFromJSON()method is invoked twice for every token verification this PR proposes to only instantiate an exception if the JSON string is invalid, hence requiring the exception to actually be thrown.