Conversation
lbalmaceda
force-pushed
the
add-claim-as-map
branch
2 times, most recently
from
5640336 to
24518a9
Compare
| } | ||
|
|
||
| @Override | ||
| public Map<String, Object> asMap() throws JWTDecodeException { |
There was a problem hiding this comment.
not really this PR, but why isn't there just one ObjectMapper (even static) instead of creating a new one every time?
the same can be said about the TypeReference
There was a problem hiding this comment.
It's on our backlog to enhance this. We're thinking on moving the implementation to use Jackson's Reader and Writer.
| assertThat(backMap, hasEntry("text", (Object) "extraValue")); | ||
| assertThat(backMap, hasEntry("number", (Object) 12)); | ||
| assertThat(backMap, hasEntry("boolean", (Object) true)); | ||
| assertThat(backMap, hasKey("object")); |
There was a problem hiding this comment.
we need more "high level" tests here IMHO, we're just using the same implementation to encode & decode.
isn't somewhere tests that use a plain json string? I think we should add there one example claim of this type and test that everything works as expected
There was a problem hiding this comment.
I think I added the tests you're asking for, considering this PR adds only the ability to "get as map" and not the verify/create.
lbalmaceda
force-pushed
the
add-claim-as-map
branch
from
adbbd91 to
574115f
Compare
lbalmaceda
force-pushed
the
add-claim-as-map
branch
from
574115f to
0a0e83a
Compare
2 participants
This PR introduces the option to get a
ClaimasMap<String, Object>.example usage:
Fixes #146