Fix stringifying Uint8Array

code-asher · code-asher · commit fe107802e383 · 2019-02-21T14:11:49.000-06:00
diff --git a/packages/protocol/src/common/util.ts b/packages/protocol/src/common/util.ts
@@ -31,6 +31,7 @@ export type IEncodingOptionsCallback = IEncodingOptions | ((err: NodeJS.ErrnoExc
  */
 export const stringify = (arg: any): string => { // tslint:disable-line no-any
 	if (arg instanceof Error) {
+		// Errors don't stringify at all. They just become "{}".
 		return JSON.stringify({
 			type: "Error",
 			data: {
@@ -39,6 +40,15 @@ export const stringify = (arg: any): string => { // tslint:disable-line no-any
 				stack: arg.stack,
 			},
 		});
+	} else if (arg instanceof Uint8Array) {
+		// With stringify, these get turned into objects with each index becoming a
+		// key for some reason. Then trying to do something like write that data
+		// results in [object Object] being written. Stringify them like a Buffer
+		// instead.
+		return JSON.stringify({
+			type: "Buffer",
+			data: Array.from(arg),
+		});
 	}
 
 	return JSON.stringify(arg);
