X Tutup
Skip to content

TST: Remove Travis#468

Merged
adrn merged 1 commit intoastropy-learn:masterfrom
pllim:rm-travis
Nov 18, 2020
Merged

TST: Remove Travis#468
adrn merged 1 commit intoastropy-learn:masterfrom
pllim:rm-travis

Conversation

@pllim
Copy link
Copy Markdown
Contributor

@pllim pllim commented Nov 18, 2020

Close #467

@kakirastern said Travis isn't used anyway? If it does, you can close this without merge and open a new PR to do the port to Actions.

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Nov 18, 2020

CircleCI failure unrelated.

@kakirastern
Copy link
Copy Markdown
Contributor

Strange, it's a KeyError:

KeyErrorTraceback (most recent call last)
<ipython-input-14-3cb6373bfea7> in <module>
      1 # Query for Herschel data in a 1 degree radius around the SMC
----> 2 result = ESASky.query_region_maps('SMC', radius=1*u.deg, missions='Herschel')
      3 
      4 print(result)

~/project/venv/lib/python3.7/site-packages/astroquery/esasky/core.py in query_region_maps(self, position, radius, missions, get_query_payload, cache)
    236         self._store_query_result_maps(query_result, sanitized_missions,
    237                                       coordinates, sanitized_radius,
--> 238                                       get_query_payload, cache)
    239 
    240         if (get_query_payload):

~/project/venv/lib/python3.7/site-packages/astroquery/esasky/core.py in _store_query_result_maps(self, query_result, missions, coordinates, radius, get_query_payload, cache)
    768             mission_table = self._query_region_maps(coordinates, radius,
    769                                                     mission, get_query_payload,
--> 770                                                     cache)
    771             if (len(mission_table) > 0):
    772                 query_result[mission.upper()] = mission_table

~/project/venv/lib/python3.7/site-packages/astroquery/esasky/core.py in _query_region_maps(self, coordinates, radius, observation_name, get_query_payload, cache)
    682         query = (
    683             self._build_observation_query(coordinates, radius,
--> 684                                           self._find_observation_parameters(observation_tap_name)))
    685         request_payload = self._create_request_payload(query)
    686         if (get_query_payload):

~/project/venv/lib/python3.7/site-packages/astroquery/esasky/core.py in _build_observation_query(self, coordinates, radius, json)
    711         from_query = " FROM {}".format(json[self.__TAP_TABLE_STRING])
    712         if (radiusDeg != 0 or json[self.__IS_SURVEY_MISSION_STRING]):
--> 713             if (json[self.__IS_SURVEY_MISSION_STRING]):
    714                 where_query = (" WHERE 1=CONTAINS(pos, CIRCLE('ICRS', {}, {}, {}));".
    715                                format(ra, dec, radiusDeg))

KeyError: 'isSurveyMission'
KeyError: 'isSurveyMission'

@kakirastern
Copy link
Copy Markdown
Contributor

On the astroquery side too

@kakirastern
Copy link
Copy Markdown
Contributor

Think I may need to make a patch at astroquery or open an issue there at least...

@kakirastern
Copy link
Copy Markdown
Contributor

Definitely not a server-side issue (but a syntax issue).

@adrn
Copy link
Copy Markdown
Contributor

adrn commented Nov 18, 2020

For the failing build, see #463 and #470

@adrn adrn merged commit 5aa40b4 into astropy-learn:master Nov 18, 2020
@adrn
Copy link
Copy Markdown
Contributor

adrn commented Nov 18, 2020

Thanks @pllim

@pllim pllim deleted the rm-travis branch November 18, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: Use GitHub Actions

3 participants

X Tutup