Add Celestial Coords 1 tutorial notebook [new content]#453
Add Celestial Coords 1 tutorial notebook [new content]#453adrn merged 6 commits intoastropy-learn:masterfrom kakirastern:celestial-coords1
Conversation
|
@eblur @kelle @stargaser Due to some technical issues I needed to open a new PR for the 1st Celestial Coords tutorial. Will follow up here instead moving forward. |
|
All code pushed to repo. PR is ready for a review. |
|
One quick comment: I would suggest renaming this to "Celestial Coordinates with WCS 1: ...". Taking a look at the infrastructure aspects now! |
adrn
left a comment
There was a problem hiding this comment.
Looks good to me from an infrastructure perspective!
But: for consistency with other notebooks, could you merge the first cell (the title) with the next cell (header info / authors). You can also remove the "**" (bold), because the header will be bold by default.
Sure, just merged the first two markdown cells, and removed the bolding effect from the headings. |
stargaser
left a comment
There was a problem hiding this comment.
I like this version. I've made some suggestions about the file download and access, and the packages in pip-requirements.txt.
|
For the file download part, it would also work to do which is more lines of code than opening the URL directly, or using |
|
But I do have reservations about using |
|
Very minor note: I think the |
Sure, will make the changes soon. |
|
Am changing the temporary downloading path to https://github.com/astropy/astropy-data/raw/6d92878d18e970ce6497b70a9253f65c925978bf/tutorials/celestial-coords1/tailored_dss.22.29.38.50-20.50.13_60arcmin.fits before PR is ready to be merged by maintainers. |
|
This is ready for another review before the corresponding astropy/astropy-data#95 PR is merged, since the final link from there will be required for maintainers to merge this PR. |
Update download link for Helix FITS file
Edits to celestial coords 1 tutorial
adrn
left a comment
There was a problem hiding this comment.
I did my main review via pull request to @kakirastern's branch here, so I'm happy with the notebook now! One minor remaining thing: I think we can remove requests from the requirements files?
Yup, done 👍 |
|
🎉 Thanks @kakirastern ! |
|
Awesome! Appreciate it @adrn 👍 |
Fixes #443.
Fixes #436 due to a new bug in GitHub.
Address #400, though not completely fixing it.
Add new FITS World Coordinate System (WCS) tutorial to guide users on how to building one's own
astropy.wcs.WCSobject, serving as an intro toWCSusing astropy in two ways programmatically. In addition, a simple way to add a scale bar with thematplotlibpackage has been introduced.