Add 'pyproject' to types_or for ruff checks#158
Draft
mxr wants to merge 1 commit intoastral-sh:mainfrom
Draft
Conversation
ntBre
reviewed
Mar 3, 2026
| entry: ruff check --force-exclude | ||
| language: python | ||
| types_or: [python, pyi, jupyter] | ||
| types_or: [python, pyi, jupyter, pyproject] |
Contributor
There was a problem hiding this comment.
Is this a valid file type for pre-commit? I tried running the identify-cli command as described in the docs, and the results for pyproject.toml were:
["file", "non-executable", "text", "toml"]
So I'm not sure this will work.
Author
There was a problem hiding this comment.
Thanks for looking. identify-cli PR is at pre-commit/identify#581. I plan to keep this PR as a draft until that one is resolved.
bn-andrew
approved these changes
Mar 3, 2026
bn-andrew
left a comment
bn-andrew
left a comment
There was a problem hiding this comment.
Nice one, pending that upgrade in identify 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows ruff to check RUF200 and other checks in pyproject.toml
Test Plan
pre-commit try-repo