This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Allow lazy loading with AngularSpa in dev build#1195
Closed
frederikprijck wants to merge 2 commits intoaspnet:devfrom
frederikprijck:fix/lazyloading
Closed
Allow lazy loading with AngularSpa in dev build#1195frederikprijck wants to merge 2 commits intoaspnet:devfrom frederikprijck:fix/lazyloading
frederikprijck wants to merge 2 commits intoaspnet:devfrom
frederikprijck:fix/lazyloading
Conversation
Previously, the AngularSpa didn't include `angular2-router-loader`. This commit ensures it does. Closes #1194
|
@frederikprijck, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@frederikprijck, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Contributor
|
This would be an ideal addition to the base repo, as otherwise devs will think they're doing something wrong when following lazy-loading instructions. |
MarkPieszak
approved these changes
Aug 21, 2017
Member
|
Thanks! This is now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the AngularSpa didn't include
angular2-router-loader.This commit ensures it does.
This closes #1194