[Lua] Add eyedropper action to useTool#5692
Open
Gasparoken wants to merge 1 commit intoaseprite:betafrom
Open
Conversation
aseprite-bot
reviewed
Mar 6, 2026
Collaborator
aseprite-bot
left a comment
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| // Get the first point from the points table | ||
| lua_pushnil(L); | ||
| if (lua_next(L, -2) != 0) { | ||
| gfx::Point pt = convert_args_into_point(L, -1); |
Collaborator
There was a problem hiding this comment.
warning: variable 'pt' of type 'gfx::Point' (aka 'PointT') can be declared 'const' [misc-const-correctness]
Suggested change
| gfx::Point pt = convert_args_into_point(L, -1); | |
| gfx::Point const pt = convert_args_into_point(L, -1); |
dacap
reviewed
Mar 6, 2026
Comment on lines
+454
to
+455
| type = lua_getfield(L, 1, "points"); | ||
| if (type == LUA_TTABLE) { |
Member
There was a problem hiding this comment.
It looks like these lines are duplicated, probably checking for the "points" tablet is the first thing we can do, and after that decide the eyedropper path or the ToolLoop one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.