llext: adding missing heap when llext is disabled#331
Draft
andreagilardoni wants to merge 8 commits intoarduino:mainfrom
Draft
llext: adding missing heap when llext is disabled#331andreagilardoni wants to merge 8 commits intoarduino:mainfrom
andreagilardoni wants to merge 8 commits intoarduino:mainfrom
Conversation
andreagilardoni
force-pushed
the
sketch-heap
branch
4 times, most recently
from
93ef78b to
3b90f8a
Compare
pillo79
requested changes
Feb 16, 2026
pillo79
left a comment
pillo79
left a comment
There was a problem hiding this comment.
Allowing to build with LLEXT=n is a worthy goal! But I believe some things need to be addressed here:
- remove the last commit (
LLEXT_EDKis an absolutely mandatory part of the build!) - fix various
_defconfigtypos in the first commit - use the opportunity to improve the logic in main.c
Thanks!
loader/main.c
Outdated
| typedef void (*entry_point_t)(struct k_heap *heap, size_t heap_size); | ||
| entry_point_t entry_point = (entry_point_t)(base_addr + HEADER_LEN + 1); | ||
| entry_point(&llext_heap, llext_heap.heap.init_bytes); | ||
| entry_point(&SKETCH_HEAP, SKETCH_HEAP.heap.init_bytes); |
There was a problem hiding this comment.
This was a bug that needed to be addressed anyway, so let's write this line like this:
Suggested change
| entry_point(&SKETCH_HEAP, SKETCH_HEAP.heap.init_bytes); | |
| entry_point(&SKETCH_HEAP, SKETCH_HEAP_SIZE); |
Author
There was a problem hiding this comment.
is entry_point expecting a KB measured or B measured value? I guess byte measured
loader/main.c
Outdated
| } | ||
| } | ||
|
|
||
| if (!IS_ENABLED(CONFIG_LLEXT)) { |
There was a problem hiding this comment.
That's enough, let's not add more #ifs please! 😁
You can replace this with a global #ifdef CONFIG_LLEXT that goes all the way to the return 0 at the end of this function. In the meantime, get rid of all the other #if CONFIG_LLEXT that are now redundant.
Author
There was a problem hiding this comment.
I would love to keep something that can notify an user that the loader is built with llext disabled when linking a sketch with dynamic link mode. I think it can be easy to forget of this build choice and troublesome to find out that the sketch is not running because of this
andreagilardoni
force-pushed
the
sketch-heap
branch
3 times, most recently
from
d3af987 to
3416a2a
Compare
andreagilardoni
force-pushed
the
sketch-heap
branch
4 times, most recently
from
5ec2d57 to
aa32654
Compare
Defined config for sketch heap size, now LLEXT_HEAP_SIZE defaults to this value Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
When llext is disabled lext-edk include file generation had a recursion bug Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
When CONFIG_LLEXT=n llext_heap is not defined, thus raising compile time error when compiling with that option disabled. NOTE that the only way to use a sketch with a loader compiled with llext disabled is to use static linkage mode. This could help save up some space. Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
This commits make it possible to have the same exported symbols as an llext build, when llext is disabled by means of: - ephemeral symbols in section .exported_sym - gen_provides: mechanism to include symbols through list of regex Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
andreagilardoni
force-pushed
the
sketch-heap
branch
from
aa32654 to
46f2a8a
Compare
Making script gen_provides avoid failing when no symbol is provided, instead it just prints a warning message. This is required to avoid extra/build.sh fail when the loader is build without llext support Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
rename kheap_llext_heap and kheap_llext_heap_size symbols to kheap__sketch_heap Signed-off-by: Andrea Gilardoni <a.gilardoni@arduino.cc>
In this way wew are able to use symbol linkage statically without the need of the entire LLEXT runtime
andreagilardoni
force-pushed
the
sketch-heap
branch
from
46f2a8a to
34b3707
Compare
Built
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Artifact | Board | Core | Tests | RAM | Sketches | Warnings | Errors | |
|---|---|---|---|---|---|---|---|---|
🔥 zephyr_contrib |
ek_ra8d1
| 🔥 | Core build failed! | |||||
frdm_mcxn947
| 🔥 | Core build failed! | ||||||
frdm_rw612
| 🔥 | Core build failed! | ||||||
🔥 zephyr_main |
giga
| 🔥 | Core build failed! | |||||
nano33ble
| 🔥 | Core build failed! | ||||||
nano_matter
| 🔥 | Core build failed! | ||||||
niclasense
| 🔥 | Core build failed! | ||||||
opta
| 🔥 | Core build failed! | ||||||
portentac33
| 🔥 | Core build failed! | ||||||
portentah7
| 🔥 | Core build failed! | ||||||
🔥 zephyr_unoq |
unoq
| 🔥 | Core build failed! | |||||
Legend
Board Test Status description 🔥 🔥 Test run failed to complete. ❌ 🔴 Test completed with unexpected errors. ✔️* 🚫 Test completed with errors, but all are known/expected. ✅* 🟡 Test completed with some warnings; no errors detected. ✅ 🟢 Test passed successfully, with no warnings or errors. 🌑 🌑 Test was skipped.
Caution
zephyr_contrib is blocked due to failures on ek_ra8d1, frdm_mcxn947, frdm_rw612!
Caution
zephyr_main is blocked due to failures on giga, nano33ble, nano_matter, niclasense, opta, portentac33, portentah7!
Caution
zephyr_unoq is blocked due to failures on unoq!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CONFIG_LLEXT=n llext_heap is not defined, thus raising compile time error when compiling with that option disabled. A further generic config is added, in order to customize the size of the heap (SKETCH_HEAP_SIZE)
NOTE that the only way to use a sketch with a loader compiled with llext disabled is to use static linkage mode. This could help save up some space.