feat: allow non-href links extract & enqueue#1781
Open
kozlice wants to merge 4 commits intoapify:masterfrom
Open
feat: allow non-href links extract & enqueue#1781kozlice wants to merge 4 commits intoapify:masterfrom
kozlice wants to merge 4 commits intoapify:masterfrom
Conversation
vdusek
reviewed
Mar 9, 2026
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Thank you! Two comments...
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Pijukatel
approved these changes
Mar 9, 2026
Collaborator
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Just an optional style comment on tests
|
|
||
| await crawler.run(requests) | ||
|
|
||
| first_visited = visit.call_args_list[0][0][0] |
Collaborator
There was a problem hiding this comment.
Preferably, use mock assert helpers instead of digging through the call list
For example:
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.call_count
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls
vdusek
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now
hrefattribute is hardcoded forenqueue_linksandextract_linksmethods.This change would allow to:
Examples:
Issues
?
Testing
Covered by new tests.
Checklist