X Tutup
Skip to content

[Fix] VMware to KVM migration instances listing failure#12766

Open
nvazquez wants to merge 1 commit intoapache:4.22from
shapeblue:422-vmware-to-kvm-listing-fix
Open

[Fix] VMware to KVM migration instances listing failure#12766
nvazquez wants to merge 1 commit intoapache:4.22from
shapeblue:422-vmware-to-kvm-listing-fix

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Mar 9, 2026

Description

This PR fixes instances listing from VMware vCenters for migration to KVM due to NPE on EFI settings on some VMware VMs

Fixes: #12647

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Changes tested by @rosi-achmad on #12647 (comment)

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (c3d6a8c) to head (db0602d).

Files with missing lines Patch % Lines
...in/java/com/cloud/hypervisor/vmware/mo/BaseMO.java 0.00% 1 Missing ⚠️
...com/cloud/hypervisor/vmware/util/VmwareHelper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12766   +/-   ##
=========================================
  Coverage     17.61%   17.61%           
- Complexity    15661    15666    +5     
=========================================
  Files          5917     5917           
  Lines        531402   531402           
  Branches      64971    64971           
=========================================
+ Hits          93586    93606   +20     
+ Misses       427262   427240   -22     
- Partials      10554    10556    +2     
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.68% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nvazquez
Copy link
Contributor Author

nvazquez commented Mar 9, 2026

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17041

@nvazquez
Copy link
Contributor Author

nvazquez commented Mar 9, 2026

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland linked an issue Mar 9, 2026 that may be closed by this pull request
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17043

@nvazquez
Copy link
Contributor Author

nvazquez commented Mar 9, 2026

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17047

@nvazquez
Copy link
Contributor Author

nvazquez commented Mar 9, 2026

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import-Export from External Vcenter unable to list instance

4 participants

X Tutup