feat: Improve Playwright test patterns in dag-runs-tab.spec.ts#63189
Open
Desel72 wants to merge 2 commits intoapache:mainfrom
Open
feat: Improve Playwright test patterns in dag-runs-tab.spec.ts#63189Desel72 wants to merge 2 commits intoapache:mainfrom
Desel72 wants to merge 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Author
|
Hi @choo121600 Please review this pr and share any feedback. thank you |
choo121600
reviewed
Mar 10, 2026
Member
choo121600
left a comment
choo121600
left a comment
There was a problem hiding this comment.
It looks like the test is failing.
Could you check it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
dag-runs-tab.spec.tsReplace anti-patterns in
DagRunsTabPage.tsanddag-runs-tab.spec.tswithPlaywright best practices:
page.locator('[data-testid="..."]')withpage.getByTestId("...")a[href...]selectors withgetByRole("link")locatorspage.waitForURL()with web-firstexpect(page).toHaveURL()locator("tbody tr")withlocator("tbody").getByRole("row")This PR focuses on improving test patterns only. It does not change test
coverage or behavior.
closes: #63165
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.