X Tutup
Skip to content

fix(app): make provider icon resolved id reactive#15583

Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom
neriousy:fix-provider-icon-reactivity
Mar 1, 2026
Merged

fix(app): make provider icon resolved id reactive#15583
adamdotdevin merged 1 commit intoanomalyco:devfrom
neriousy:fix-provider-icon-reactivity

Conversation

@neriousy
Copy link
Contributor

@neriousy neriousy commented Mar 1, 2026

Issue for this PR

Closes #15581 fixes regression introduced in #15295

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes updating the provider icon in the model select

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

  1. Open app in dev since there's no release yet
  2. Change model with different provider

Screenshots / recordings

2026-03-01.15-15-12.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions github-actions bot added contributor needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Mar 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@neriousy neriousy marked this pull request as ready for review March 1, 2026 14:16
Copilot AI review requested due to automatic review settings March 1, 2026 14:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a UI regression where the provider icon in the model select did not update when the provider/model changed, by making the resolved icon ID reactive in the ProviderIcon component.

Changes:

  • Make resolved provider icon ID reactive via createMemo.
  • Update <use href> to consume the memoized icon ID accessor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neriousy neriousy changed the title fix(ui): make provider icon resolved id reactive fix(app): make provider icon resolved id reactive Mar 1, 2026
@adamdotdevin adamdotdevin merged commit c8866e6 into anomalyco:dev Mar 1, 2026
21 of 22 checks passed
Grappeggia pushed a commit to teamslop/slopcode that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop / app - provider icons are not updating

3 participants

X Tutup